Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conventionalize yaml-register behavior #28

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shigma
Copy link

@shigma shigma commented Apr 26, 2022

Fixes: #15

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2022

🦋 Changeset detected

Latest commit: 927748a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
yaml-register Minor
@proload/plugin-yaml Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shigma
Copy link
Author

shigma commented Apr 26, 2022

@natemoo-re do I need to update changeset for this PR?

@natemoo-re
Copy link
Owner

Yes please, that would be great @shigma! You can run yarn changeset locally and select minor since this is still a 0.x.x package.

@shigma
Copy link
Author

shigma commented May 2, 2022

Sorry to bother you, is there anything else to do before this PR is merged? I really miss this feature.

@natemoo-re
Copy link
Owner

Sorry @shigma, just circling back to this finally, I'll get this merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yaml-register does not actually "register"
2 participants