Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Saturation Warnings more obvious for users #64

Open
natashabatalha opened this issue Jun 13, 2022 · 0 comments
Open

Make Saturation Warnings more obvious for users #64

natashabatalha opened this issue Jun 13, 2022 · 0 comments

Comments

@natashabatalha
Copy link
Owner

In the python interface, users have to manually check output['warings'] dictionary key to see if they have saturated pixels. Hard saturated pixels need to be more directly obvious. This can be accomplished through:

  • user warnings
  • printouts in verbose=True mode
  • colored pixels in jpi.jwst_1d_spec

In the meantime, users should be in the habit of checking their output. E.g.

exo = jdi.load_exo_dict('LTT-1445 A b')
exo['observation']['sat_level']=80
exo['observation']['sat_unit']='%'
exo['planet']['type']='constant'
exo['planet']['f_unit']='rp^2/r*^2'
output = jdi.run_pandexo(exo, ['NIRSpec Prism'])

Gives the warnings:

>>> output['warning']
{'Group Number Too Low?': 'All good', 
'Group Number Too High?': 'All good', 
'Non linear?': 'All good', 'Saturated?': 
'Full saturation:\n There are 644 pixels saturated at the end of the first group. These pixels cannot be recovered.', 
'% full well high?': 'All good', 
'Num Groups Reset?': 'NGROUPS<2SET TO NGROUPS=2'}

Which shows the user it is saturated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant