Connection pool - The default implementation is not recommended for production use

[calleay]

Hello,

For both the Dremio and Dremio+Flight dialects, the SingletonThreadPool connection pool implementation is used by default.

While this configuration can be easily overridden, it would possibly be safer to use a different connection pool implementation as this one is not recommended for production use and can cause some inconvenient behaviors in a production setup (e.g., connection randomly closed in the middle of a query execution).
See https://docs.sqlalchemy.org/en/14/core/pooling.html#sqlalchemy.pool.SingletonThreadPool for further detail.

sqlalchemy_dremio/sqlalchemy_dremio/base.py

Lines 142 to 148 in b87c878

	class DremioDialect(default.DefaultDialect):
	name = 'dremio'
	supports_sane_rowcount = False
	supports_sane_multi_rowcount = False
	poolclass = pool.SingletonThreadPool
	statement_compiler = DremioCompiler

sqlalchemy_dremio/sqlalchemy_dremio/flight.py

Lines 146 to 153 in b87c878

	class DremioDialect_flight(default.DefaultDialect):
	name = 'dremio+flight'
	supports_sane_rowcount = False
	supports_sane_multi_rowcount = False
	poolclass = pool.SingletonThreadPool
	statement_compiler = DremioCompiler

Thanks again and keep up with the good work 🙂