-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some features exist for TempoPulsar
but not for PintPulsar
objects.
#303
Comments
Features 1 and 2 can be put in... 1 is easy if you know where to find the information in PINT (I don't, but could look). 2 is almost there, it just needs restructuring As for 3, I think that PINT does not provide those planets, so we should open an issue on the PINT repository. Right @Hazboun6 ? |
Why are those planets necessary? We can totally add them, but Mercury and Pluto?!? And I suspect that even Venus and Mars are way more precise than we need, no? |
They're not necessary. We're just getting carried away by feature parity... they are not a priority. |
Also, I just checked and it looks like |
This one was from a discussion with someone the other day. It must have been added recently, and I should have checked! |
@scottransom and @vallis I agree that most of those are probably not needed. And definitely don't need to be a priority. I will say that the PPTA coded up a version of |
I'm writing this issue as a request to add certain features to the
PintPulsar
class which already exist for theTempoPulsar
class.Add ability to get DMX values fromPintPulsar
classPintPulsar
into shared memory to reduce total memory required when using PTMCMCSamplerPintPulsar
Are there other differences that I have missed?
The text was updated successfully, but these errors were encountered: