Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShadSlider doesn't have a focus indicator #204

Open
helightdev opened this issue Nov 30, 2024 · 2 comments
Open

ShadSlider doesn't have a focus indicator #204

helightdev opened this issue Nov 30, 2024 · 2 comments
Assignees
@helightdev
Labels
accepted A valid and reproducible issue bug Something isn't working waiting for customer response Cannot make further progress on this issue until the original reporter responds

Comments

@helightdev
Copy link
Contributor

helightdev commented Nov 30, 2024 •
edited
Loading

Steps to reproduce

Select a slider using Tab

Expected results

The official shadcn implementation draws a second circle arround the slider when selected.

Actual results

When selecting a slider using Tab, no indication is given that the slider is selected even though it can be manipulated.

shadcn_ui version

main

Platform

Web

Code sample

Screenshots or Video

What it should look like:
Screenshot 2024-11-29 221842

Logs

No response

Flutter Doctor output

.
@helightdev helightdev added bug Something isn't working triage Issues that need assessment and prioritization labels Nov 30, 2024
@helightdev helightdev mentioned this issue Nov 30, 2024
Open
@helightdev
Copy link
Contributor Author

I changed the thumb and slider state to draw an indicator like in the official shadcn implementation.

@nank1ro nank1ro added accepted A valid and reproducible issue and removed triage Issues that need assessment and prioritization labels Dec 2, 2024
@nank1ro
Copy link
Owner

nank1ro commented Dec 22, 2024

Hey @helightdev can you address the required changes in the PRs?
Otherwise I will continue them in the next days

@nank1ro nank1ro added the waiting for customer response Cannot make further progress on this issue until the original reporter responds label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@helightdev helightdev

Labels
accepted A valid and reproducible issue bug Something isn't working waiting for customer response Cannot make further progress on this issue until the original reporter responds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@helightdev @nank1ro