Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting scrollBehavior has no effect #179

Closed
dickermoshe opened this issue Oct 28, 2024 · 1 comment · Fixed by #180
Closed

Setting scrollBehavior has no effect #179

dickermoshe opened this issue Oct 28, 2024 · 1 comment · Fixed by #180
Assignees
Labels
bug Something isn't working

Comments

@dickermoshe
Copy link
Contributor

Steps to reproduce

  1. Set a scrollBehavior on ShadAPp

Expected results

Use the scrollBehavior

Actual results

It does not.

shadcn_ui version

0.14.0

Platform

MacOS, Windows, Linux, Android, iOS, Web

Code sample

Code sample

Run on desktop!

import 'dart:ui';

import 'package:flutter/material.dart';
import 'package:shadcn_ui/shadcn_ui.dart';

void main() {
  runApp(const MainApp());
}

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return ShadApp.material(
      scrollBehavior: const MaterialScrollBehavior().copyWith(
          dragDevices: {PointerDeviceKind.touch, PointerDeviceKind.mouse}),
      home: Scaffold(
        body: ListView.builder(
          itemBuilder: (context, index) => ListTile(title: Text("Item $index")),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration

With ShadApp:

Recording.2024-10-27.225016.mp4

With MaterialApp:

Recording.2024-10-27.225119.mp4

Logs

Logs
[Paste your logs here]

Flutter Doctor output

Doctor output
[√] Flutter (Channel stable, 3.24.3, on Microsoft Windows [Version 10.0.22631.4317], locale en-US)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.11.5)
[√] Android Studio (version 2023.1)
[√] VS Code, 64-bit edition (version 1.93.1)
[!] Proxy Configuration
    ! NO_PROXY does not contain ::1
[√] Connected device (3 available)
[√] Network resources

! Doctor found issues in 1 category.
@dickermoshe dickermoshe added the bug Something isn't working label Oct 28, 2024
@nank1ro
Copy link
Owner

nank1ro commented Oct 28, 2024

It should be fixed in the v0.14.1

@nank1ro nank1ro self-assigned this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants