Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve mysql database connection #177

Closed
nakamasato opened this issue Mar 27, 2023 · 2 comments · Fixed by #183
Closed

improve mysql database connection #177

nakamasato opened this issue Mar 27, 2023 · 2 comments · Fixed by #183

Comments

@nakamasato
Copy link
Owner

https://pkg.go.dev/database/sql#example-package-OpenDBService

currently, connection is established for every reconciliation loop, which is not effective
@nakamasato
Copy link
Owner Author

nakamasato commented Mar 29, 2023 •
edited
Loading

I tried using go-sqlmock for database mock, however calling multiple times not supported: DATA-DOG/go-sqlmock#257 so gave up using it.

@nakamasato
Copy link
Owner Author

@nakamasato nakamasato mentioned this issue Mar 30, 2023
Merged
@nakamasato nakamasato changed the title use mysql database connection pool improve mysql database connection Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use shared MySQLClients nakamasato/mysql-operator
1 participant
@nakamasato