Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add finalizer to mysql_controller #168

Merged
merged 4 commits into from
Mar 27, 2023
Merged

fix: add finalizer to mysql_controller #168

merged 4 commits into from
Mar 27, 2023

Conversation

nakamasato
Copy link
Owner

@nakamasato nakamasato commented Mar 26, 2023 •
edited
Loading

Why

What

  • Add finalizer to check if there's no dependent objects for MySQL before deletion
  • Add controller test to check finalizer is added when creating a new object

@codecov
Copy link

codecov bot commented Mar 26, 2023 •
edited
Loading

Codecov Report

Merging #168 (54fbdef) into main (94efefb) will increase coverage by 0.17%.
The diff coverage is 47.82%.

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   73.29%   73.47%   +0.17%     
==========================================
  Files           5        5              
  Lines         397      411      +14     
==========================================
+ Hits          291      302      +11     
- Misses         79       82       +3     
  Partials       27       27
Impacted Files Coverage Δ
controllers/mysqluser_controller.go 71.81% <33.33%> (+1.86%) ⬆️
controllers/mysql_controller.go 72.58% <52.94%> (-7.42%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nakamasato nakamasato marked this pull request as ready for review March 27, 2023 00:26
@nakamasato nakamasato merged commit 83a018d into main Mar 27, 2023
@nakamasato nakamasato deleted the fix-bug-of-mysql-deletion-before-mysqluser branch March 27, 2023 00:27
@nakamasato nakamasato changed the title add finalizer to mysql_controller fix: add finalizer to mysql_controller Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MySQL is removed before MySQLUser
1 participant
@nakamasato