test(iroh-cli): Also test for "minutes" in transfer time regex 😬 #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t author is persisted
From 345.82s to 116s locally.
|
🤣 |
dignifiedquire
approved these changes
Jul 8, 2024
|
Windows is confirmed less flaky now: |
divagant-martian
changed the title
|
😂 maybe we should be adding "hours" already... thanks for working on these! |
matheus23
added a commit
that referenced
this pull request
Nov 14, 2024
## Description Windows CI was so slow, the transfer was measured in *minutes*, not *seconds* and printed as such to the CLI. The CLI tests only expected "seconds" to be printed though. 😬 Also went ahead and improved performance of `make_test_file` because damn this test is already slow enough. ## Breaking Changes None ## Notes & open questions Idk, do you have any? :P ## Change checklist - [X] Self-review. - ~~[ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - ~~[ ] Tests if relevant.~~ - ~~[ ] All breaking changes documented.~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Windows CI was so slow, the transfer was measured in minutes, not seconds and printed as such to the CLI.
The CLI tests only expected "seconds" to be printed though. 😬
Also went ahead and improved performance of
make_test_filebecause damn this test is already slow enough.Breaking Changes
None
Notes & open questions
Idk, do you have any? :P
Change checklist
[ ] Documentation updates following the style guide, if relevant.[ ] Tests if relevant.[ ] All breaking changes documented.