Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does iroh-gossip guarantee that messages sent by the same sender are received by everyone in the same order? #2360

Closed
b5 opened this issue Jun 13, 2024 · 5 comments
Labels
c-iroh-gossip docs Improvements or additions to documentation

Comments

@b5
Copy link
Member

b5 commented Jun 13, 2024

I'm almost positive it doesn't, but either way, we need to document an answer on what the current behavior is

@b5 b5 added docs Improvements or additions to documentation c-iroh-gossip labels Jun 13, 2024
@link2xt
Copy link
Contributor

link2xt commented Jun 13, 2024

Related deltachat issue: deltachat/deltachat-core-rust#5688
Delta Chat does not need guarantee, but reordering should not be introduced on the sender if possible, e.g. no spawning of tasks for each message sent etc. If packets are lost/reordered on IP level or gossip tree is rebuilt (i.e. there are routing changes), then reordering gossip messages is fine.

@divagant-martian
Copy link
Contributor

divagant-martian commented Jun 13, 2024

There is no notion of order in gossip at all, and a perceived non-order is expected simply given the existence of lazy peers, which might be eager peers of our eager peers. This is a known not-guarantee and I doubt we should try to make it one even in the simple cases

@link2xt
Copy link
Contributor

link2xt commented Jun 13, 2024

This happens even when I have only two peers. One node is sending data and there seems to be no reason the second node receives it in the other order.

@link2xt
Copy link
Contributor

link2xt commented Jun 17, 2024

The issue can probably be closed on the iroh side, I made a python test and don't see any reordering when sending 200 messages in a row: deltachat/deltachat-core-rust#5696
So likely the problem is somewhere on the higher layer, e.g. Delta Chat UI or Node.js bot.

@dignifiedquire
Copy link
Contributor

Thanks, closing, please let us know if you find an issue with iroh

@github-project-automation github-project-automation bot moved this to ✅ Done in iroh Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-iroh-gossip docs Improvements or additions to documentation
Projects
Archived in project
Development

No branches or pull requests

4 participants