feat(iroh): allow custom protocols with optional manual accept #2284
Conversation
| /// | ||
| /// The default is [`AcceptMode::Auto`], which accepts all iroh protocol automatically and does | ||
| /// not allow to use custom protocols. | ||
| pub fn accept_mode(mut self, accept_mode: AcceptMode) -> Self { |
There was a problem hiding this comment.
I like passing the mode instead of having accept_manual().
| /// | ||
| /// This method will panic unless [`Builder::accept_mode`] was called with | ||
| /// [`AcceptMode::Manual`] | ||
| pub async fn accept_connection(&self) -> Option<Connecting> { |
There was a problem hiding this comment.
Do we need this at all? Can we just let people call accept on the endpoint?
https://docs.rs/iroh/latest/iroh/node/struct.Node.html#method.magic_endpoint
There was a problem hiding this comment.
I like this approach better than some elaborate scheme with ALPN handlers. I think the complexity is acceptable for advanced use cases, and having some handler trait scheme will break down in many cases.
One thing I was wondering: you can already get the endpoint from the node. So what would happen if somebody would just grab an endpoint and then call accept on it, in the current code? Who wins? Is it round robin?
https://docs.rs/iroh/latest/iroh/node/struct.Node.html#method.magic_endpoint
Frando
changed the title
Frando
changed the title
Yes, it would be round-robin I think, same as You could already do this now by the way - the endpoint is already exposed (as you linked). You really shouldn't though because behavior would be unpredictable. We could remove Node::accept in the PR, it would be identical to calling node.magic_endpoint().accept. |
Yeah, with some of these APIs we really assume people know what they are doing, so we might as well let them do endpoint().accept(), then it becomes clearer that this is not some special stuff but just a good old incoming connection handler. |
|
Closing in favor of #2357 |
Description
allow to manually accept connections and use custom protocols together with iroh core
see the included example which uses both a custom protocol and core iroh protocols.
Breaking Changes
Notes & open questions
Change checklist