Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky test: test_icmp_probe_eu_relayer seems to be flaky on windows #2239

Closed
divagant-martian opened this issue Apr 25, 2024 · 1 comment
Closed
Milestone

Comments

@divagant-martian
Copy link
Contributor

run failure : https://github.com/n0-computer/iroh/actions/runs/8839402059/job/24272669544?pr=2238

failure sample

--- STDOUT:              iroh-net netcheck::reportgen::tests::test_icmpk_probe_eu_relayer ---

running 1 test
2024-04-25T21:17:39.922749Z DEBUG iroh_net::netcheck::reportgen: 947: Performing DNS A lookup for relay addr proto=IcmpV4 hostname=euw1-1.relay.iroh.network.
2024-04-25T21:17:39.922958Z DEBUG hickory_proto::xfer::dns_handle: 67: querying: euw1-1.relay.iroh.network. A
2024-04-25T21:17:39.923010Z DEBUG hickory_resolver::name_server::name_server_pool: 258: sending request: [Query { name: Name("euw1-1.relay.iroh.network."), query_type: A, query_class: IN }]
2024-04-25T21:17:39.923081Z DEBUG hickory_resolver::name_server::name_server: 105: reconnecting: NameServerConfig { socket_addr: 185.12.64.1:53, protocol: Udp, tls_dns_name: None, trust_negative_responses: false, tls_config: None, bind_addr: None }
2024-04-25T21:17:39.923151Z DEBUG hickory_proto::xfer: 171: enqueueing message:QUERY:[Query { name: Name("euw1-1.relay.iroh.network."), query_type: A, query_class: IN }]
2024-04-25T21:17:39.923178Z DEBUG hickory_resolver::name_server::name_server: 105: reconnecting: NameServerConfig { socket_addr: 185.12.64.2:53, protocol: Udp, tls_dns_name: None, trust_negative_responses: false, tls_config: None, bind_addr: None }
2024-04-25T21:17:39.923194Z DEBUG hickory_proto::xfer: 171: enqueueing message:QUERY:[Query { name: Name("euw1-1.relay.iroh.network."), query_type: A, query_class: IN }]
2024-04-25T21:17:39.923308Z DEBUG hickory_proto::udp::udp_client_stream: 228: final message: ; header 16455:QUERY:RD:NoError:QUERY:0/0/0
; query
;; euw1-1.relay.iroh.network. IN A

2024-04-25T21:17:39.923375Z DEBUG hickory_proto::udp::udp_client_stream: 228: final message: ; header 11281:QUERY:RD:NoError:QUERY:0/0/0
; query
;; euw1-1.relay.iroh.network. IN A

2024-04-25T21:17:39.924339Z DEBUG hickory_proto::udp::udp_stream: 310: created socket successfully
2024-04-25T21:17:39.924433Z DEBUG hickory_proto::udp::udp_stream: 310: created socket successfully
test netcheck::reportgen::tests::test_icmpk_probe_eu_relayer ... FAILED

failures:

failures:
    netcheck::reportgen::tests::test_icmpk_probe_eu_relayer

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 88 filtered out; finished in 3.39s


--- STDERR:              iroh-net netcheck::reportgen::tests::test_icmpk_probe_eu_relayer ---
thread 'netcheck::reportgen::tests::test_icmpk_probe_eu_relayer' panicked at iroh-net\src\netcheck\reportgen.rs:1327:14:
called `Result::unwrap()` on an `Err` value: "No suitable relay addr found: deadline has elapsed"
@ramfox ramfox moved this to 🏗 In progress in iroh Apr 26, 2024
@ramfox ramfox moved this from 🏗 In progress to 📋 Backlog in iroh Apr 26, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 26, 2024
…#2240)

## Description

As described in #2239 

## Breaking Changes

n/a

## Notes & open questions

dns issue? why only the eu_relayer? - discussion for the issue

## Change checklist

- [x] Self-review.
- [ ] ~Documentation updates if relevant.~
- [ ] ~Tests if relevant.~
- [ ] ~All breaking changes documented.~
@dignifiedquire dignifiedquire modified the milestones: v0.15.0, v0.16.0 Apr 29, 2024
@ramfox ramfox changed the title test_icmpk_probe_eu_relayer seems to be flaky on windows flakey test: test_icmpk_probe_eu_relayer seems to be flaky on windows Apr 29, 2024
@ramfox ramfox changed the title flakey test: test_icmpk_probe_eu_relayer seems to be flaky on windows flaky test: test_icmpk_probe_eu_relayer seems to be flaky on windows Apr 29, 2024
@flub flub changed the title flaky test: test_icmpk_probe_eu_relayer seems to be flaky on windows flaky test: test_icmp_probe_eu_relayer seems to be flaky on windows May 7, 2024
@flub
Copy link
Contributor

flub commented May 7, 2024

This looks like DNS on windows problem, not icmp. So I'm going to consider this a duplicate of #2086

@flub flub closed this as completed May 7, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in iroh May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants