refactor!: avoid using futures crate directly #2117
Conversation
dignifiedquire
force-pushed
the
refactor-futures
branch
from
88facb2 to
975c903
Compare
|
What about we do an |
dignifiedquire
force-pushed
the
refactor-futures
branch
2 times, most recently
from
6344bf8 to
65b277f
Compare
dignifiedquire
force-pushed
the
refactor-futures
branch
from
65b277f to
6ee446b
Compare
|
is this still alive? should we get it done? |
this is blocked on n0-computer/quic-rpc#71 |
|
@dignifiedquire I pushed a fix to your compile errors |
dignifiedquire
changed the title
dignifiedquire
changed the title
There was a problem hiding this comment.
It would be nice if you could constrain futures_lite to the imports. But if you do use futures_lite::future that collides with the import of std::future that you sometimes have to do to use the anemic standardized futures api. So 🤷. If futures_lite would reexport the std futures stuff this would not be an issue, but I guess they did not want to do that.
Also I really don't get what was wrong with the BoxFuture and BoxStream type aliases in futures.
| @@ -250,15 +253,6 @@ impl<D: BaoStore> Node<D> { | |||
| } | |||
| } | |||
|
|
|||
| /// The future completes when the spawned tokio task finishes. | |||
| impl<D> Future for Node<D> { | |||
There was a problem hiding this comment.
I don't mind losing this at all.
Due to the low maintenance and absurd high amount of `unsafe` code in
parts of the `futures` crate, we are trying to avoid usage of it.
Usages are replaced with
- `futures-lite` : general `Future` and `Stream` tooling
- `futures-sink`: `Sink` trait
- `futures-buffered`: faster and safer version of `Futures{Un}Ordered`
- If must be `futures-util` for sink specific things that are missing
## Breaking Changes
- `iroh::node::Node` does not implement `Future` anymore
- `iroh::node::Node::shutdown()` is now `async` and can be awaited upon
to wait for the node to exit
- `iroh_net::util::AbortingJoinHandle`s inner field is not public
anymore, use the `From<JoinHandle>` implementation to contruct it
## Followups
- [x] Apply this to `bao-tree`:
n0-computer/bao-tree#49
- [x] Apply this to `iroh-io`:
n0-computer/iroh-io#6
- [x] Apply this to `quic-rpc`:
n0-computer/quic-rpc#73
---------
Co-authored-by: Ruediger Klaehn <[email protected]>
Due to the low maintenance and absurd high amount of
unsafecode in parts of thefuturescrate, we are trying to avoid usage of it.Usages are replaced with
futures-lite: generalFutureandStreamtoolingfutures-sink:Sinktraitfutures-buffered: faster and safer version ofFutures{Un}Orderedfutures-utilfor sink specific things that are missingBreaking Changes
iroh::node::Nodedoes not implementFutureanymoreiroh::node::Node::shutdown()is nowasyncand can be awaited upon to wait for the node to exitiroh_net::util::AbortingJoinHandles inner field is not public anymore, use theFrom<JoinHandle>implementation to contruct itFollowups
bao-tree: refactor: use futures-lite instead of futures bao-tree#49iroh-io: refactor: replace futures with futures-lite iroh-io#6quic-rpc: refactor: no more futures crate quic-rpc#73