From 6d29f84949d28d3fc58f59c093769c5f2085a563 Mon Sep 17 00:00:00 2001 From: Floris Bruynooghe Date: Tue, 23 Apr 2024 17:30:20 +0200 Subject: [PATCH] tests: Remove flaky label from windows-DNS affected tests They have been stable on CI for a while now. Maybe the DNS config tweak we did a while ago made a difference. --- iroh-net/src/dns.rs | 2 -- iroh-net/src/netcheck/reportgen.rs | 1 - 2 files changed, 3 deletions(-) diff --git a/iroh-net/src/dns.rs b/iroh-net/src/dns.rs index 7cfb3117fb..e3d165e9ba 100644 --- a/iroh-net/src/dns.rs +++ b/iroh-net/src/dns.rs @@ -155,7 +155,6 @@ pub(crate) mod tests { use super::*; #[tokio::test] - #[cfg_attr(target_os = "windows", ignore = "flaky")] async fn test_dns_lookup_basic() { let _logging = iroh_test::logging::setup(); let resolver = default_resolver(); @@ -166,7 +165,6 @@ pub(crate) mod tests { } #[tokio::test] - #[cfg_attr(target_os = "windows", ignore = "flaky")] async fn test_dns_lookup_ipv4_ipv6() { let _logging = iroh_test::logging::setup(); let resolver = default_resolver(); diff --git a/iroh-net/src/netcheck/reportgen.rs b/iroh-net/src/netcheck/reportgen.rs index 1cf6be7084..6859395036 100644 --- a/iroh-net/src/netcheck/reportgen.rs +++ b/iroh-net/src/netcheck/reportgen.rs @@ -1315,7 +1315,6 @@ mod tests { // /etc/sysctl.conf or /etc/sysctl.d/* to persist this accross reboots. // // TODO: Not sure what about IPv6 pings using sysctl. - #[cfg_attr(target_os = "windows", ignore = "flaky")] #[tokio::test] async fn test_icmpk_probe_eu_relayer() { let _logging_guard = iroh_test::logging::setup();