Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect removing duplicate donations from the same person #1

Open
ajparsons opened this issue Oct 9, 2024 · 0 comments
Open

Incorrect removing duplicate donations from the same person #1

ajparsons opened this issue Oct 9, 2024 · 0 comments

Comments

@ajparsons
Copy link
Contributor

We currently for the excel sheet group based on the free_text of an interest, to show the first and last time it appeared.

The assumption there are no duplicate freetexts in the same register for a person. This isn't true - and the better data validation makes it easier for things to be declared exactly the same twice.

(Some of these might be reporting duplicates, but are assigned different ids in parliament).

So when grouping, we need to keep these somehow.

Possible approach:

  • When looking at individual registers, assign an additional 'dup_number' based on the same text and person_id.
  • Then when adding up group on person, free_text, dup_number - which will in most cases be 1.

Order shouldn't matter here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant