Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action fails to install older emscripten version due to mismatch between emsdk main and tagged emscripten versions #45

Open
akien-mga opened this issue May 7, 2024 · 0 comments

Comments

@akien-mga
Copy link

See emscripten-core/emsdk#1379 for context, there's been a change to filenames for some of the artifacts downloaded by emsdk, and somehow this started breaking stuff today.

The upstream recommendation is that for a given emscripten version, one should use the matching emsdk version, but this action always downloads the latest emsdk main branch:

const emsdkArchive = await tc.downloadTool("https://github.com/emscripten-core/emsdk/archive/main.zip");

I would suggest changing this to follow the version config, so if e.g. requesting emscripten 3.1.39, it would download https://github.com/emscripten-core/emsdk/archive/3.1.39.zip

This could be made configurable via a emsdk_version that could default to the same value as version, but could be overridden to e.g. main if someone knows they need latest emsdk regardless of the emscripten version they request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant