Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isango discord login wont transfer profile picture/name #55

Open
deffcolony opened this issue Dec 1, 2020 · 6 comments
Open

Isango discord login wont transfer profile picture/name #55

deffcolony opened this issue Dec 1, 2020 · 6 comments
Labels
feature New feature or request
Milestone

Comments

@deffcolony
Copy link

Hi,

The plugin Isango is great with the discord registration feature only the problem is when i try to register on MYBB with the discord login it wont transfer the profile picture and name used on ur discord profile. It only transfer ur email name as username thats a privacy issue the discord login feature should transfer the profile name and profile picture from ur discord account

@effone
Copy link
Member

effone commented Dec 12, 2020

We didn't consider those transfer as not all OAuth provider returns avatar and / or username.
I'll however willing to work on it further to consider those return values if available in response.

Thanks for raising the issue.

@effone effone added the feature New feature or request label Dec 30, 2020
@effone effone added this to the 1.3.0 milestone Dec 30, 2020
@Eldenroot
Copy link
Member

Maybe the username would be enough... avatar sync is nice and useful, but it will require a lot of more work to do (which could be an issue if we will add a lot of providers... to maintain it). Good idea so maybe in future?

@effone
Copy link
Member

effone commented Jan 16, 2021

Avatar is already planned. The only to-do is if the remote avatar is not allowed we need to cache a local copy.
... and to identify which all gateways provide avatar URLs and by which parameter. Like this:
https://github.com/mybbgroup/Isango/blob/master/upload/inc/plugins/isango/wordpress.ini#L15

@Eldenroot
Copy link
Member

@effone - so avatar would be synced only during the registration, right? Because if it would be on every login, it will overwrite your local avatar settings which is not good.

@effone
Copy link
Member

effone commented Jan 16, 2021

Only at the time of registration. Yes.

@Eldenroot
Copy link
Member

OK, cool. Maybe we should open a new issue with all gateways which are supported right now and write where the sync of avatar is missing to track a progress. I will do that, OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants