Add ability to include headers and footers in exported HTML / Markdown #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marginalhours
force-pushed
the
master
branch
from
fd8ab03
to
68657ab
Compare
|
I seem to have some Travis issues, but I don't think I've changed anything that would materially affect the build process, and it seems to be working on 2.6! Any ideas? |
|
Your PR looks great, I can confirm I get the same error on current build. So it has nothing to do with your PR. I have submitted an issue (#68) |
marginalhours
force-pushed
the
master
branch
from
bbf2588
to
c7f091b
Compare
marginalhours
force-pushed
the
master
branch
from
c7f091b
to
676c721
Compare
|
@MisterKeefe Travis issues have been fixed. Can you fetch the latest updates? |
|
@GitBruno thanks for the heads-up, I've pulled them into this branch 👍 |
|
Any idea when this will be merged? Also is it functional for node.js? |
This was referenced Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new keyword arguments to the HTML and Markdown conversion API. These arguments allow for the inclusion of headers and footers in the output. By default, the options are False, so existing behaviour is not affected.
include_headers_and_footers: If enabled, includes header text at start of output, and appends footer text to end.deduplicate_headers_and_footers: If enabled, headers and footers will be deduplicated based on their text content.I have tried to keep the PR in the spirit of the library, in the sense that it is the information content of headers and footers which is retrieved, rather than any formatting details.
Please let me know what you think!