Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dict consistency and RAW codes #39

Open
bjonnh opened this issue Jun 10, 2021 · 2 comments
Open

Dict consistency and RAW codes #39

bjonnh opened this issue Jun 10, 2021 · 2 comments

Comments

@bjonnh
Copy link
Contributor

bjonnh commented Jun 10, 2021

Could it be possible to have/discuss:

  • To make the index accessible on the API (proposed Serve the dictionary. #46 )
  • Guarantees that the numbering will not change from the index (related to Maintenance? #6, found that later)
  • A way to get raw values from the API (get the numbers from the index instead of text form)

I saw #35 was there a change in the index with the new model?

@mwang87
Copy link
Owner

mwang87 commented Jun 10, 2021

@ChungmaruQ

This was referenced Jun 10, 2021
@ChungmaruQ
Copy link
Collaborator

ChungmaruQ commented Jun 11, 2021

Hi! @bjonnh

It is really grateful to leave your disccusion.

Guarantees that the numbering will not change from the index (related to #6, found that later)

Yes we should have done that.
During the improvement of NPClassifier and its ontology, I missed that point.

Every numbering will be consistent and new classes will be added to the next.

About returning the raw values, I'll open the PR for that.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants