Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace net/History with standard window.History #116

Open
zship opened this issue Jun 25, 2014 · 1 comment
Open

Replace net/History with standard window.History #116

zship opened this issue Jun 25, 2014 · 1 comment
Milestone

Comments

@zship
Copy link
Contributor

zship commented Jun 25, 2014

Older browsers could use a polyfill.

Files which depend on net/History:
lavaca/src/mvc/Application.js
lavaca/src/mvc/Router.js
lavaca/src/mvc/Controller.js
lavaca-starter/src/www/js/app/app.js
lavaca-starter/src/www/js/app/ui/views/BaseView.js

These would need to be checked to conform to the History API.

@zship zship added this to the 3.0 milestone Jul 1, 2014
@zship zship removed the enhancement label Jul 21, 2014
@zship
Copy link
Contributor Author

zship commented Jul 29, 2014

Thinking this through more, we may not be able to avoid having our own History implementation.

  1. We do back-button detection in here in mvc/Router and here in net/History. We use that for the direction of animations in lavaca-starter's BaseView here. The History API doesn't provide this.
  2. We seem to use net/History's hash-based method for URLs in most projects. I think this is because no server support is required for routing, which is fair.

@zship zship removed the v3 label Jul 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant