Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert singletons to plain classes (mvc/Router, mvc/ViewManager, util/Config) #115

Open
zship opened this issue Jun 25, 2014 · 0 comments
Milestone

Comments

@zship
Copy link
Contributor

zship commented Jun 25, 2014

There are plenty of arguments out there against singletons (check the Wikipedia article, second paragraph), but my main beef is that they're impossible to subclass and they make it possible to access global state (which I'd try to avoid when possible). Instead, we can instantiate them from mvc/Application.

@zship zship changed the title Convert singletons to plain classes (mvc/Router and mvc/ViewManager) Convert singletons to plain classes (mvc/Router, mvc/ViewManager, util/Config) Jun 25, 2014
@zship zship added the v3 label Jun 27, 2014
@zship zship added this to the 3.0 milestone Jul 1, 2014
@zship zship removed the enhancement label Jul 21, 2014
@zship zship removed the v3 label Jul 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant