Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type as a property name does not work #44

Closed
digiz3d opened this issue Oct 7, 2023 · 3 comments · Fixed by #45
Closed

type as a property name does not work #44

digiz3d opened this issue Oct 7, 2023 · 3 comments · Fixed by #45

Comments

@digiz3d
Copy link
Contributor

digiz3d commented Oct 7, 2023 •
edited
Loading

As talked about in #37
A type like

type SomePayload {
  type: String!
}

Will panic because of a GraphQL parsing error when it encounters the inner type keyword

Here is the PR #43 with reproducible example 👌
@mununki
Copy link
Owner

mununki commented Oct 7, 2023

Thanks! Will fix soon.

@mununki mununki mentioned this issue Oct 9, 2023
Merged
@mununki
Copy link
Owner

mununki commented Oct 9, 2023

I believe that It is fixed in v0.2.11. Can you test with it?

@digiz3d
Copy link
Contributor Author

digiz3d commented Oct 31, 2023

Indeed this specific issue is now gone !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix property name as type mununki/gqlmerge
2 participants
@digiz3d @mununki