Added cli validators test in pytest and CI for localnet dependent tests. #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - name: Test localnet dependent tests | ||
| run: | | ||
| pytest -m require_localnet . | ||
|
|
There was a problem hiding this comment.
Maybe we should stop the localnet as well?
https://github.com/multiversx/mx-sdk-js-core/blob/main/.github/workflows/test-localnet.yml#L61
There was a problem hiding this comment.
the runner dies immediately after the test if finished from what I know. I don't think there is a need to teardown
…tests." This reverts commit 4067411.
popenta
reviewed
Nov 7, 2024
|
|
||
| if [ -n "$USE_PROXY" ]; then | ||
| source ./test_cli_validators.sh && testAll | ||
| source ./test_cli_tx.sh && testAll | ||
| source ./test_cli_config.sh && testAll |
There was a problem hiding this comment.
this can be removed together with the test_cli_config.sh file.
popenta
reviewed
Nov 7, 2024
Comment on lines
6
to
7
| source ./shared.sh | ||
| source ./test_cli_validators.sh && testAll |
There was a problem hiding this comment.
not sure why this is here and not in the testAll function
popenta
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.