Fixed "stringIsFloat" issue for huge decimal numbers #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiroMargineanu
changed the title
razvantomegea
approved these changes
Nov 20, 2024
CiprianDraghici
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Checking if a string is a floating number would wrongfully return
falsefor amounts with many decimals points, such as0.0000000011231723871623178236182376123, that exceeds the default decimal places ofBigNumber.jsset at20.Issue exists on version
3.0.11ofmx-sdk-dapp.Fix
Added a
BigNumber.setmethod to set the decimal places to whatever the decimals' length is. Otherwise, keep it to the default one.Contains breaking changes
Updated CHANGELOG
Testing