-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redistribute fees collector fees #974
Redistribute fees collector fees #974
Conversation
Coverage SummaryTotals
FilesExpand
|
Contract comparison - from 17b9601 to f3f689a
|
} | ||
|
||
let mut rem_rew_entry = remaining_rewards.get_mut(i); | ||
rem_rew_entry.amount -= &reward_amount; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure the rem_rew_entry tokenId is the same as weekly_reward? And that it will be regardless of any setting that the owner may change? I would add an extra check here, just to be safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm pretty sure. They're both set at lines 178-179 in this file, and they initially have the exact same tokens and values too.
continue; | ||
} | ||
|
||
self.accumulated_fees(current_week, &reward_entry.token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we just accumulate the remaining rewards, with no means of claiming them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, they're put in current week storage, so users can claim them starting next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be merged until we have a clear launch date.
No description provided.