Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tutorial for multikey #918

Draft
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

katunopolis
Copy link

Description of the pull request (what is new / what has changed)

Did you test the changes locally ?

  • yes
  • no

Which category (categories) does this pull request belong to?

  • document new feature
  • update documentation that is not relevant anymore
  • add examples or more information about a component
  • fix grammar issues
  • other

@katunopolis
Copy link
Author

@iulianpascalau please review

@iulianpascalau iulianpascalau self-requested a review June 10, 2024 10:16
@iulianpascalau iulianpascalau changed the base branch from main to development June 10, 2024 10:16

Make sure that all operations from step 6 are made as quickly as possible. In case this step takes a long time, the backup multikey group should take over.

:::caution
Always attempt this process while closely monitor your nodes. If done correctly, your nodes might experience a brief rating drop (until the backup group takes over - if necessary)
:::

### Setup a multikey node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better to go before L316 (Migration guide from single-key operation to multikey)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not done

docs/validators/key-management/multikey-nodes.md Outdated Show resolved Hide resolved
docs/validators/key-management/multikey-nodes.md Outdated Show resolved Hide resolved
docs/validators/key-management/multikey-nodes.md Outdated Show resolved Hide resolved
docs/validators/key-management/multikey-nodes.md Outdated Show resolved Hide resolved
docs/validators/key-management/multikey-nodes.md Outdated Show resolved Hide resolved
docs/validators/key-management/multikey-nodes.md Outdated Show resolved Hide resolved
docs/validators/key-management/multikey-nodes.md Outdated Show resolved Hide resolved
@@ -332,6 +326,12 @@ Whenever deciding to switch from single-key operation to multikey, the following

Make sure that all operations from step 6 are made as quickly as possible. In case this step takes a long time, the backup multikey group should take over.

:::warning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change? I think the warning should be put before the script


Make sure that all operations from step 6 are made as quickly as possible. In case this step takes a long time, the backup multikey group should take over.

:::caution
Always attempt this process while closely monitor your nodes. If done correctly, your nodes might experience a brief rating drop (until the backup group takes over - if necessary)
:::

### Setup a multikey node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants