Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sovereign] Clean factories for run type components #6672

Open
wants to merge 5 commits into
base: feat/chain-go-sdk
Choose a base branch
from
Open

[sovereign] Clean factories for run type components #6672

wants to merge 5 commits into from

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Dec 12, 2024 •
edited
Loading

Reasoning behind the pull request

  • Cleanup factory creation in run type components

Proposed changes

  • Delete unnecessary cluttered code

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Base automatically changed from MX-15513-incoming-header-proc-cleanup to feat/chain-go-sdk December 13, 2024 10:05
@mariusmihaic mariusmihaic marked this pull request as ready for review December 13, 2024 10:15
@mariusmihaic mariusmihaic self-assigned this Dec 13, 2024
axenteoctavian
axenteoctavian reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@axenteoctavian axenteoctavian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • run long tests
  • run sovereign tests

process/block/preprocess/smartContractResultPreProcessorFactory_test.go
"testing"

"github.com/multiversx/mx-chain-go/testscommon/common"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad imports formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axenteoctavian axenteoctavian axenteoctavian left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@mariusmihaic mariusmihaic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariusmihaic @axenteoctavian