Skip to content

V3 fixes

V3 fixes #507

GitHub Actions / clippy failed Jun 13, 2024 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (2)

esdt-safe/src/lib.rs|346 col 20| warning: equality checks against false can be replaced by a negation
--> esdt-safe/src/lib.rs:346:20
|
346 | if updated == false {
| ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: !updated
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
= note: #[warn(clippy::bool_comparison)] on by default
esdt-safe/src/lib.rs|346 col 20| warning: equality checks against false can be replaced by a negation
--> esdt-safe/src/lib.rs:346:20
|
346 | if updated == false {
| ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: !updated
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
= note: #[warn(clippy::bool_comparison)] on by default

Filtered Findings (1)

multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs|251 col 27| error[E0599]: no method named set_mint_balances found for struct ContractInfo<Proxy<VMHooksApi<StaticApiBackend>>> in the current scope
--> multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs:251:42
|
251 | .call(self.esdt_safe.set_mint_balances(
| ---------------^^^^^^^^^^^^^^^^^ method not found in ContractInfo<Proxy<VMHooksApi<StaticApiBackend>>>
|
= note: the full type name has been written to '/home/runner/work/mx-bridge-eth-sc-rs/mx-bridge-eth-sc-rs/target/debug/deps/multi_transfer_blackbox_test-e4582c92a9735343.long-type-3045844397118124820.txt'

Annotations

Check warning on line 346 in esdt-safe/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] esdt-safe/src/lib.rs#L346

warning: equality checks against false can be replaced by a negation
   --> esdt-safe/src/lib.rs:346:20
    |
346 |                 if updated == false {
    |                    ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!updated`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
    = note: `#[warn(clippy::bool_comparison)]` on by default
Raw output
esdt-safe/src/lib.rs:346:20:w:warning: equality checks against false can be replaced by a negation
   --> esdt-safe/src/lib.rs:346:20
    |
346 |                 if updated == false {
    |                    ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!updated`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
    = note: `#[warn(clippy::bool_comparison)]` on by default


__END__

Check warning on line 346 in esdt-safe/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] esdt-safe/src/lib.rs#L346

warning: equality checks against false can be replaced by a negation
   --> esdt-safe/src/lib.rs:346:20
    |
346 |                 if updated == false {
    |                    ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!updated`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
    = note: `#[warn(clippy::bool_comparison)]` on by default
Raw output
esdt-safe/src/lib.rs:346:20:w:warning: equality checks against false can be replaced by a negation
   --> esdt-safe/src/lib.rs:346:20
    |
346 |                 if updated == false {
    |                    ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!updated`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
    = note: `#[warn(clippy::bool_comparison)]` on by default


__END__