Temporary fix projectiles crash during disconnecting #3876 #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
TheNormalnij
reviewed
Dec 7, 2024
Comment on lines
+51
to
+52
| if (!projectileInfoInterface->pEntProjectileOwner || projectileInfoInterface->pEntProjectileOwner->nType == ENTITY_TYPE_NOTHING || projectileInfoInterface->pEntProjectileOwner->pReferences == reinterpret_cast<void*>(0x80808080)) | ||
| bBlow = false; |
There was a problem hiding this comment.
You need to find a reason why pEntProjectileOwner was freed.
It looks like MTA doesn't delete all projectiles while disconnecting.
There was a problem hiding this comment.
This is not the goal of this PR. This PR is only a temporary solution to prevent the game from crashing. If you want, feel free to investigate the cause and open a PR with the fix, and then I'll close mine. For now, this PR is just a temporary crash patch.
There was a problem hiding this comment.
Temporary solutions have a high chance to become permanent.
The solution is too dirty. We don't rush with this issue.
TracerDS
approved these changes
Dec 7, 2024
FileEX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #3876
The crash occurs in the function
CEntity::RegisterReferencebecause, at the moment of creating an explosion for a projectile, for an unknown reason, the memory where the projectile's creator (the player disconnecting from the server) is located is freed and becomes0x80808080. I haven’t investigated the cause of where and why the memory is being freed before the projectile is destroyed. In any case, removing projectiles without the explosion resolves the crash. Besides, the explosion during the server quit doesn’t make sense anyway because we can't see it