GetPedControlState returns true for the other player when using setPedControlState for yourself

[EnoNeK]

Describe the bug

If you use setPedControlState on yourself, then getPedControlState used on a nearby player will return true, even if the player is not executing any controls

Steps to reproduce

1. Set yourself a control for example vehicle_left
   setPedControlState(localPlayer, "vehicle_left", true)
2. Now use getPedControlState on the player next to you with the same control we set for ourselves

local player = getPlayerFromName("xyz") 
outputChatBox(inspect(getPedControlState(player, "vehicle_left")))

You can now see that the function will return true if the player does not turn left

Version

Client: 1.6-release-22789
Server: 1.6-release-22789

[Lpsd]

mtasa-blue/Client/mods/deathmatch/logic/luadefs/CLuaPedDefs.cpp

Line 1283 in 650d50e

CClientPed* pPed = CStaticFunctionDefinitions::GetLocalPlayer();

The Lua definition doesn't read the ped argument from getPedControlState, it always uses the local player. Not sure how long it's been like that lol

[Lpsd]

Since 934ba8c you can't set/get control state other than local player.

The note on https://wiki.multitheftauto.com/wiki/SetPedControlState needs updating as it's incorrect

[TheNormalnij]

int CLuaPedDefs::GetPedControlState(lua_State* luaVM)
{
    // Verify the argument
    CClientPed*      pPed = CStaticFunctionDefinitions::GetLocalPlayer();
    SString          strControl = "";
    CScriptArgReader argStream(luaVM);

    if (argStream.NextIsUserData())
    {
        argStream.ReadUserData(pPed);
    }

Are you sure?

[ds1-e]

#3867 kinda related