Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RaisedButton] Wrong ripple position with custom styles. #6272

Closed
NewOldMax opened this issue Mar 3, 2017 · 7 comments
Closed

[RaisedButton] Wrong ripple position with custom styles. #6272

NewOldMax opened this issue Mar 3, 2017 · 7 comments
Labels
component: button This is the name of the generic UI component, not the React module! v0.x

Comments

@NewOldMax
Copy link

Problem description

After updating to 0.17.0 I have an issue with raised buttons with custom styles. See example below
asd27
As you can see, ripple has wrong position. In previous versions all works fine.

Link to minimally-working code that reproduces the issue

http://www.webpackbin.com/NJY7WMGqz

Versions

  • Material-UI: 0.17.0
  • React: 15.4.2
  • Browser: Chrome 56
@dhavalsoni2001
Copy link

Webpackbin link is not working. Can you please share it again?

@NewOldMax
Copy link
Author

https://www.webpackbin.com/bins/-KeXtsrRsCDqBykNIePr
As I see, all old webpackbin links not working...

@dhavalsoni2001
Copy link

dhavalsoni2001 commented Mar 6, 2017

Ripple effect works with Label. You used in webpackbin
const style = {

  buttonLabel: {
    margin: '15px 0 0 0',
    display: 'block'
  },

So Ripple effect also start after 15px margin. I replace margin to padding and its working fine.

@NewOldMax
Copy link
Author

I see... But in previous versions margins worked fine... Is there some breaking changes?

@dhavalsoni2001
Copy link

dhavalsoni2001 commented Mar 6, 2017 via email

@NewOldMax
Copy link
Author

Oh, I see the problem.
0.16.5
asd29

0.17.0
asd28

Seems that previously, there was no focus effect on button

@oliviertassinari
Copy link
Member

We have been porting the component on the v1-beta branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.
Still, we will accept PR fixes until v1-beta takes over the master branch.

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added component: button This is the name of the generic UI component, not the React module! v0.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! v0.x
Projects
None yet
Development

No branches or pull requests

4 participants