Calling a dialog element inside a dialog element disable the scroll

[dalizwei]

Hello,
I tried for some days to figure out a solution for this problem without success.
I'm calling a dialog element like DatePicker inside an other dialog element 'x'.
When i close 'x' the scroll of the main page(the page containing the first dialog 'x') get disabled.
Thanks for helping.

[oliviertassinari]

That seems an issue with the ordre in which componentWillUnmont is called https://github.com/callemall/material-ui/blob/master/src/overlay.jsx#L50.

[dalizwei]

So the componentWillUnmont of DatePicker is called after Dialog 'x' applying the _originalBodyOverflow of Dialog 'x' to the main page?
If it's the problem, is there a way to fix it?

[oliviertassinari]

So the componentWillUnmont of DatePicker is called after Dialog 'x' applying the _originalBodyOverflow of Dialog 'x' to the main page?

This is what I though, but no, according to:

componentDidMount of a parent gets called after componentDidMount of its children, so you know your children are fully initialized before using them.
facebook/react#4752 (comment)

This bug doesn't make sense to me.

[dalizwei]

Searching deeply, i saw that componentWillUnmont in the overlay.jsx was the problem.
removing it like this dalizwei@4864eb6 solved the problem and i kept the good behavior of the page.
Something else i found is that allowing and preventing the scroll is also done by _applyAutoLockScrolling when the props show get updated so what is the purpose of componentWillUnmont here ?

[oliviertassinari]

what is the purpose of componentWillUnmont here ?

That's to make sure the body.style.overflow will have the correct value event if the <Dialog /> is unmonted while opened.

[dalizwei]

So it would be better to test if the Dialog is open before running _allowScrolling() like this dalizwei@4864eb6.
Still fix the problem for me, but i don't know if it's the best way to deal with it.

[elca2712]

Hi, I have the same problem with dialog in dialogs, I do the fix like this https://github.com/elca2712/material-ui/commit/616b528a1fecf8f7e86e63964d435be4b227485c

This way it prevent to set an overflow:hidden on already empty overflow when _allowScrolling is called.