Set TERM environment variable in shell process. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some shells like `fish` require the TERM environment variable to be set to determine whether a terminal emulator has color support, etc. Since DTerm has support for colors, set the value to `xterm-256color` for maximum support.
|
This fix might also help when dterm is calling a shell script which uses the |
ethanliu
added a commit
to ethanliu/dterm
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16. Some shells like
fishrequire the TERM environment variable to be set todetermine whether a terminal emulator has color support, etc. Since DTerm has
support for colors, set the value to
xterm-256colorfor maximum support.I have not actually been able to get color working correctly from
fishyet, but this at least silences the warning at the beginning of the prompt and should improve support from other commands that look for$TERMin their environment. If I am able to improve color support more I will open another PR.