Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[서준환] 4장: 실용주의 편집증 #39

Merged
merged 1 commit into from
Aug 19, 2024
Merged

[서준환] 4장: 실용주의 편집증 #39

merged 1 commit into from
Aug 19, 2024

Conversation

Seojunhwan
Copy link
Member

No description provided.

@github-actions github-actions bot added the 4장 label Aug 12, 2024
hyesungoh
hyesungoh approved these changes Aug 13, 2024
View reviewed changes
4장/서준환.md

> 생각해보면 라이브러리단에서도 에러 처리할 때 메시지가 명확한 라이브러리가 있는 반면 그렇지 않은 라이브러리들도 있었던 것 같아요.
>
> 만드시는 라이브러리가 있다면 오류 처리는 어떻게 해주고 계시나요? 저는 `suspensive` 이 라이브러리의 오류 처리 참고해서 처리 하는 중입니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 핑거프린스라 .. 대략 어떤 느낌인지 공유해주셔도 좋을 거 같아오 😋 😭 :rage4:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아아 고냥 에러 메시지도 명확하게 분리해 주신 것이 너무 좋더라구요!

또 대혜성님의 킹랩 axios instance 부분도 예전에 잘 보았읍니다, , ,

4장/서준환.md
Comment on lines +89 to +91
우리는 미래의 유지 보수를 고려해서 설계해야하지만, 우리가 볼 수 있는 미래까지만 고려해야한다.

> 어느정도 반성을 하게끔 만드는 문장입니다 , , 늘 미래를 바라봤었는데 잘못된 방향이었을 수도 있다는 생각이 드네요.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍 👍 👍

4장/서준환.md

두번째 이유는 해당 함수 내부에서 일어나는 모든 예외를 처리해 주어야 하고, 추가된다면 해당 throw에서도 추가해줘야 한다.

> 보통 어떻게 처리하세요?
Copy link
Member

@hyesungoh hyesungoh Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그냥 망가지게 둡니다

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제일 좋은 방법이라고 생각합니동

100Gyeon
100Gyeon approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@100Gyeon 100Gyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

4장/서준환.md

죽은 프로그램이 끼치는 피해는 이상한 상태의 프로그램이 끼치는 피해보다 훨씬 적다는 듣다보면 맞는 느낌이 드네요.

## 단정적 프로그래밍
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

발표 때 공유해 주신 console.assert 기억하겠습니다 🙇🏻‍♀️

@Seojunhwan Seojunhwan merged commit e4c7e12 into main Aug 19, 2024
1 check passed
@Seojunhwan Seojunhwan deleted the 4장/서준환 branch August 19, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjoleee sjoleee sjoleee approved these changes

@gutenLEE gutenLEE gutenLEE approved these changes

@100Gyeon 100Gyeon 100Gyeon approved these changes

@hyesungoh hyesungoh hyesungoh approved these changes

@Dongkyuuuu Dongkyuuuu Awaiting requested review from Dongkyuuuu Dongkyuuuu is a code owner

@metacode22 metacode22 Awaiting requested review from metacode22 metacode22 is a code owner

@Orchemi Orchemi Awaiting requested review from Orchemi Orchemi is a code owner

@sangbooom sangbooom Awaiting requested review from sangbooom sangbooom is a code owner

@sumi-0011 sumi-0011 Awaiting requested review from sumi-0011 sumi-0011 is a code owner

Assignees

@Seojunhwan Seojunhwan

Labels
4장
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Seojunhwan @hyesungoh @100Gyeon @gutenLEE @sjoleee @metacode22