From 0f0d86b6710d969603a905f54b17cd5dbd32dfaf Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Wed, 30 Aug 2023 10:20:14 -0700 Subject: [PATCH] Update the system dependency tests to use the built gem This would better reflect how users might install the gem. --- .github/workflows/tests.yml | 8 ++++++-- scripts/test-gem-install | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 1426b05..487451e 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -14,6 +14,7 @@ on: jobs: compile-and-test-system-dependencies: + needs: ["build-cruby-gem"] name: System Dependencies - Ruby ${{ matrix.ruby }} - libre2 ABI version ${{ matrix.libre2.soname }} runs-on: ubuntu-20.04 strategy: @@ -57,8 +58,11 @@ jobs: with: ruby-version: "${{ matrix.ruby }}" bundler-cache: true - - run: bundle exec rake compile -- --enable-system-libraries - - run: bundle exec rake spec + - uses: actions/download-artifact@v3 + with: + name: cruby-gem + path: gems + - run: ./scripts/test-gem-install gems --enable-system-libraries compile-and-test-vendored-dependencies: name: Vendored Dependencies - Ruby ${{ matrix.ruby }} - ${{ matrix.runs-on }} diff --git a/scripts/test-gem-install b/scripts/test-gem-install index 3783967..63e99e8 100755 --- a/scripts/test-gem-install +++ b/scripts/test-gem-install @@ -30,4 +30,4 @@ bundle install --local || bundle install cd $(dirname `gem which re2`) cd .. -rake spec +rspec