forked from zmap/zlint
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
19 changed files
with
667 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
v3/lints/cabf_br/lint_aia_ca_issuers_must_have_http_only.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| package cabf_br | ||
|
|
||
| /* | ||
| * ZLint Copyright 2024 Regents of the University of Michigan | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy | ||
| * of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
| * implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "net/url" | ||
|
|
||
| "github.com/zmap/zcrypto/x509" | ||
| "github.com/zmap/zlint/v3/lint" | ||
| "github.com/zmap/zlint/v3/util" | ||
| ) | ||
|
|
||
| type bRAIACAIssuersHasHTTPOnly struct{} | ||
|
|
||
| /************************************************************************ | ||
| 7.1.2.7.7 Subscriber Certificate Authority Information Access | ||
| The AuthorityInfoAccessSyntax MUST contain one or more AccessDescriptions. Each | ||
| AccessDescription MUST only contain a permitted accessMethod, as detailed below, and | ||
| each accessLocation MUST be encoded as the specified GeneralName type. | ||
| The AuthorityInfoAccessSyntax MAY contain multiple AccessDescriptions with the | ||
| same accessMethod, if permitted for that accessMethod. When multiple | ||
| AccessDescriptions are present with the same accessMethod, each accessLocation | ||
| MUST be unique, and each AccessDescription MUST be ordered in priority for that | ||
| accessMethod, with the most‐preferred accessLocation being the first | ||
| AccessDescription. No ordering requirements are given for AccessDescriptions that | ||
| contain different accessMethods, provided that previous requirement is satisfied. | ||
| id-ad-caIssuers | ||
| 1.3.6.1.5.5.7.48.2 uniformResourceIdentifier SHOULD A HTTP URL of the | ||
| Issuing CA’s certificate | ||
| *************************************************************************/ | ||
|
|
||
| func init() { | ||
| lint.RegisterCertificateLint(&lint.CertificateLint{ | ||
| LintMetadata: lint.LintMetadata{ | ||
| Name: "e_aia_ca_issuers_must_have_http_only", | ||
| Description: "The id-ad-caIssuers accessMethod must contain an HTTP URL of the Issuing CA’s certificate. Other schemes are not allowed.", | ||
| Citation: "BRs: 7.1.2.7.7", | ||
| Source: lint.CABFBaselineRequirements, | ||
| EffectiveDate: util.SC62EffectiveDate, | ||
| }, | ||
| Lint: NewBRAIACAIssuersHasHTTPOnly, | ||
| }) | ||
| } | ||
|
|
||
| func NewBRAIACAIssuersHasHTTPOnly() lint.LintInterface { | ||
| return &bRAIACAIssuersHasHTTPOnly{} | ||
| } | ||
|
|
||
| func (l *bRAIACAIssuersHasHTTPOnly) CheckApplies(c *x509.Certificate) bool { | ||
| return len(c.IssuingCertificateURL) > 0 && util.IsSubscriberCert(c) | ||
| } | ||
|
|
||
| func (l *bRAIACAIssuersHasHTTPOnly) Execute(c *x509.Certificate) *lint.LintResult { | ||
| for _, u := range c.IssuingCertificateURL { | ||
| purl, err := url.Parse(u) | ||
| if err != nil { | ||
| return &lint.LintResult{Status: lint.Error, Details: "Could not parse caIssuers in AIA."} | ||
| } | ||
| if purl.Scheme != "http" { | ||
| return &lint.LintResult{Status: lint.Error, Details: fmt.Sprintf("Found scheme %s in caIssuers of AIA, which is not allowed.", purl.Scheme)} | ||
| } | ||
| } | ||
| return &lint.LintResult{Status: lint.Pass} | ||
| } |
92 changes: 92 additions & 0 deletions
92
v3/lints/cabf_br/lint_aia_ca_issuers_must_have_http_only_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| package cabf_br | ||
|
|
||
| /* | ||
| * ZLint Copyright 2024 Regents of the University of Michigan | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy | ||
| * of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
| * implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/zmap/zlint/v3/lint" | ||
| "github.com/zmap/zlint/v3/test" | ||
| ) | ||
|
|
||
| func TestBRAIACAIssuersHasHTTPOnly(t *testing.T) { | ||
| testCases := []struct { | ||
| Name string | ||
| InputFilename string | ||
|
|
||
| ExpectedResult lint.LintStatus | ||
| ExpectedDetails string | ||
| }{ | ||
| { | ||
| Name: "error - AIA has an FTP URI for id-ad-caIssuers accessMethod.", | ||
| InputFilename: "aiaCaIssuersFTPOnly.pem", | ||
|
|
||
| ExpectedResult: lint.Error, | ||
| ExpectedDetails: "Found scheme ftp in caIssuers of AIA, which is not allowed.", | ||
| }, | ||
| { | ||
| Name: "error - AIA has an HTTP and an LDAP URI for id-ad-caIssuers accessMethod.", | ||
| InputFilename: "aiaCaIssuersHTTPAndLDAP.pem", | ||
|
|
||
| ExpectedResult: lint.Error, | ||
| ExpectedDetails: "Found scheme ldap in caIssuers of AIA, which is not allowed.", | ||
| }, | ||
| { | ||
| Name: "pass - AIA has only one HTTP URI for id-ad-caIssuers accessMethod.", | ||
| InputFilename: "aiaCaIssuersHTTPOnly.pem", | ||
|
|
||
| ExpectedResult: lint.Pass, | ||
| }, | ||
| { | ||
| Name: "error - AIA has only one HTTPS URI for id-ad-caIssuers accessMethod.", | ||
| InputFilename: "aiaCaIssuersHttpsOnly.pem", | ||
|
|
||
| ExpectedResult: lint.Error, | ||
| ExpectedDetails: "Found scheme https in caIssuers of AIA, which is not allowed.", | ||
| }, | ||
| { | ||
| Name: "NE - AIA has only one HTTP URI for id-ad-caIssuers accessMethod and it is issued before September 15th 2023.", | ||
| InputFilename: "aiaCaIssuersHttpOnlyNE.pem", | ||
|
|
||
| ExpectedResult: lint.NE, | ||
| }, | ||
| { | ||
| Name: "NA - AIA has only an id-ad-ocsp accessMethod.", | ||
| InputFilename: "aiaCaIssuersHttpOnlyNoCAIssuers.pem", | ||
|
|
||
| ExpectedResult: lint.NA, | ||
| }, | ||
| { | ||
| Name: "error - AIA has an LDAP URI for id-ad-caIssuers accessMethod.", | ||
| InputFilename: "aiaCaIssuersLDAPOnly.pem", | ||
|
|
||
| ExpectedResult: lint.Error, | ||
| ExpectedDetails: "Found scheme ldap in caIssuers of AIA, which is not allowed.", | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| t.Run(tc.Name, func(t *testing.T) { | ||
| result := test.TestLint("e_aia_ca_issuers_must_have_http_only", tc.InputFilename) | ||
| if result.Status != tc.ExpectedResult { | ||
| t.Errorf("expected result %v was %v", tc.ExpectedResult, result.Status) | ||
| } | ||
|
|
||
| if tc.ExpectedResult == lint.Error && tc.ExpectedDetails != result.Details { | ||
| t.Errorf("expected details: %q, was %q", tc.ExpectedDetails, result.Details) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
v3/lints/cabf_ev/lint_cabf_org_identifier_psd_vat_has_state.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /* | ||
| * ZLint Copyright 2024 Regents of the University of Michigan | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy | ||
| * of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
| * implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package cabf_ev | ||
|
|
||
| import ( | ||
| "github.com/zmap/zcrypto/x509" | ||
| "github.com/zmap/zlint/v3/lint" | ||
| "github.com/zmap/zlint/v3/util" | ||
| ) | ||
|
|
||
| func init() { | ||
| lint.RegisterCertificateLint(&lint.CertificateLint{ | ||
| LintMetadata: lint.LintMetadata{ | ||
| Name: "e_cabf_org_identifier_psd_vat_has_state", | ||
| Description: "The cabfOrganizationIdentifier field for PSD org VAT Registration Schemes cannot include the referenceStateOrProvince field.", | ||
| Citation: "9.2.8", | ||
| Source: lint.CABFEVGuidelines, | ||
| EffectiveDate: util.SC17EffectiveDate, | ||
| }, | ||
| Lint: NewCabfOrgIdentifierPsdVatHasState, | ||
| }) | ||
| } | ||
|
|
||
| type CabfOrgIdentifierPsdVatHasState struct{} | ||
|
|
||
| func NewCabfOrgIdentifierPsdVatHasState() lint.LintInterface { | ||
| return &CabfOrgIdentifierPsdVatHasState{} | ||
| } | ||
|
|
||
| func (l *CabfOrgIdentifierPsdVatHasState) CheckApplies(c *x509.Certificate) bool { | ||
| for _, ext := range c.Extensions { | ||
| if ext.Id.Equal(util.CabfExtensionOrganizationIdentifier) && (c.CABFOrganizationIdentifier.Scheme == "PSD" || c.CABFOrganizationIdentifier.Scheme == "VAT") { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| func (l *CabfOrgIdentifierPsdVatHasState) Execute(c *x509.Certificate) *lint.LintResult { | ||
| if c.CABFOrganizationIdentifier.State == "" { | ||
| return &lint.LintResult{Status: lint.Pass} | ||
| } else { | ||
| return &lint.LintResult{Status: lint.Error} | ||
| } | ||
| } |
31 changes: 31 additions & 0 deletions
31
v3/lints/cabf_ev/lint_cabf_org_identifier_psd_vat_has_state_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /* | ||
| * ZLint Copyright 2024 Regents of the University of Michigan | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy | ||
| * of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
| * implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package cabf_ev | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/zmap/zlint/v3/lint" | ||
| "github.com/zmap/zlint/v3/test" | ||
| ) | ||
|
|
||
| func TestCabfOrgIdentifierPsdVatHasState(t *testing.T) { | ||
| inputPath := "cabfOrgIdentifierPSDState.pem" | ||
| expected := lint.Error | ||
| out := test.TestLint("e_cabf_org_identifier_psd_vat_has_state", inputPath) | ||
| if out.Status != expected { | ||
| t.Errorf("%s: expected %s, got %s", inputPath, expected, out.Status) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.