Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to useNames hook #642

Open
josh-griffin opened this issue Dec 13, 2021 · 1 comment
Open

Add pagination to useNames hook #642

josh-griffin opened this issue Dec 13, 2021 · 1 comment
Labels

Comments

@josh-griffin
Copy link
Contributor

We should probably paginate the useNames hook.

It's possible that we don't need to, and I think this can wait for at least awhile. I believe the API has a default limit of 1000. If needed as a first step we could increase this limit. I think querying for a few thousand names should be fine, though it would be wise to check beforehand!

(I wonder if querying for a flat number of all the names initially is less bandwidth used than querying for various search inputs which each might return a few hundred each time 🤔 )

@josh-griffin
Copy link
Contributor Author

Ah, and also with pagination would come filtering on name/code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants