Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a stocktake with a selection of items created from a complex filtering #582

Open
josh-griffin opened this issue Dec 3, 2021 · 9 comments

Comments

@josh-griffin
Copy link
Contributor

josh-griffin commented Dec 3, 2021

Just like in mSupply, ability to create a stocktake from a complex query for items:

Create a new stock take with items selected from a query/filter: https://docs.google.com/spreadsheets/d/1H0Rv1DEOgW0cE07wpfc_KivLf8TcNhYDqlwRp92x-To/edit#gid=0&range=A350

image

Possibly V2 if filtering is too hard?

@mark-prins
Copy link
Contributor

We may not have all the options available in the API. I wonder about creating the selector using only the name or code filter for now, and then expanding on it for phase 2

@josh-griffin
Copy link
Contributor Author

Ah good idea!

@andreievg
Copy link

We may not have all the options available in the API. I wonder about creating the selector using only the name or code filter for now, and then expanding on it for phase 2

Would this still be blocked by API ? for v1 ?

@josh-griffin
Copy link
Contributor Author

Not sure.. had assumed v1, but at this point would likely push back 🤷

@andreievg
Copy link

I'll add it as a question for tomorrow chat

@josh-griffin
Copy link
Contributor Author

blocked by not knowing if it's needed

@josh-griffin
Copy link
Contributor Author

Mobile just has a list of all the stock items and you click a checkbox next to each. Maybe we should just do that

@andreievg
Copy link

Is the API blocked = more filters on items ?
You can use batched mutation to insert multiple stock lines, although stock line batch doesn't yet have continue_on_error, so it would error out and be canceled if at least one error happens, like if stock line already exists in stocktake, but I would assume when adding items by filters to existing stocktake, you would want to show which stock lines in the filtered list are already in stocktake, thus can do a mutation which excludes them, and even deletes lines which are 'unchecked' ?

@mark-prins
Copy link
Contributor

Mobile just has a list of all the stock items and you click a checkbox next to each. Maybe we should just do that

We should just do that. The rest of this we can do later 😜

Is the API blocked = more filters on items ?

Not any more.. we'll do that later.
Thanks, will need the batched mutation to add multiple lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants