Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimal rounding pattern/consistency #1040

Open
josh-griffin opened this issue Mar 14, 2022 · 2 comments
Open

Decimal rounding pattern/consistency #1040

josh-griffin opened this issue Mar 14, 2022 · 2 comments
Labels
Blocked system

Comments

@josh-griffin
Copy link
Contributor

josh-griffin commented Mar 14, 2022 •
edited by mark-prins
Loading

  • Money: Currently set to 10 when using useCurrency()
  • Tax: Currently set to 2 when using Formatter.tax using toFixed()
  • Others: ??

mSupply uses a pref for some of this, though I'm not sure how much.

Should use some global variable to set this for.. categories? everything?

i.e. taxDecimalPlaces: 2, moneyDecimals: 10

I know that vaccines use a decimal for quantity in mSupply, but numberOfPacks is an int in the gql schema. I can't think of other decimals off the top of my head
@josh-griffin
Copy link
Contributor Author

amc/consumption

@mark-prins mark-prins self-assigned this Apr 14, 2022
@mark-prins
Copy link
Contributor

mark-prins commented May 9, 2022 •
edited
Loading

Will require global preferences. Perhaps #1041?

@mark-prins mark-prins removed their assignment May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocked system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mark-prins @josh-griffin