Picked OS: Can no longer edit stock in invoice line if all has been issued

[roxy-dao]

What went wrong? 😲

Stock lines disappearing from invoice line after allocating all the stock since stock leaves inventory at Picked, but we are still allowing the user to edit the invoice, so the user should still be able to edit the stock.

Q. Why does OMS picked functionality have to match OG cn functionality? Why can stock not still be in inventory but just unavailable?

Expected behaviour 🤔

The user should still be able to edit the stock line!

How to Reproduce 🔨

Steps to reproduce the behaviour:

1. Create an Outbound Shipment
2. Add invoice line
3. Issue all stock from stock line
4. Change status to Picked
5. Go back to invoice line
6. See that stock line has disappeared

Your environment 🌱

• Open mSupply Version:
• Legacy mSupply Central Server Version:

• Platform:

• Database type:

[andreievg]

Q. Why does OMS picked functionality have to match OG cn functionality?

Sorry the full reasoning is a bit lost to me now, but at some point there was consensus on it, perhaps we need some documentation about it but we would need all stakeholder to participate, including mSupply pps. I feel like this area is being discussed all the time and perhaps needs a diagram and explanation ?

Why can stock not still be in inventory but just unavailable?

Stock line still exists. We should display that stock line in the list. I think it's deliberately being filtered out.

[andreievg]

Btw do we have front end test for this ?

[roxy-dao]

I think should definitely be documented since it is being discussed a lot.

[mark-prins]

no - the f/e tests are usually around logic and component functionality. this would be a b/e test or f/e-b/e integration test, if we had such a thing.

[andreievg]

I think should definitely be documented since it is being discussed a lot.

msupply-foundation/msupply_docs#32

[regotaina]

Tested on RC4
PASSED THE TEST 💯

🧪 How has/should this change been tested?

• Create an Outbound Shipment
• Add invoice line
• Issue all stock from stock line
• Change status to Picked
• Go back to invoice line
• See that stock line has disappeared