295 Fixup date truncation #296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmbrunskill
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Thanks Ethan!
I can't help but feel like it's crying out for an optimisation to get the difference in days/hours/months and then adjust based on that,b ut can definitely be in a future PR, and the original goal was to keep this logic simple so I like that you've kept it consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #295
👩🏻💻 What does this PR do?
🧪 How has/should this change been tested?
💌 Any notes for the reviewer?
📃 Documentation
No user facing changes