Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiribati Vax: Vaccine can be processed for deleted patient in vaccination lookup window #4885

Closed
nishaDangol-Sussol opened this issue Aug 16, 2022 · 4 comments · Fixed by #4893
Assignees
Labels
Bug: development Bug was found and believed to only be in development branches Docs: not needed Effort: medium Medium effort story/task, estimated 2-5 days Priority: release blocker Project: K COVID-19 Vax Issues specifically related to K COVID-19 Vax project / customisations.
Milestone

Comments

@nishaDangol-Sussol
Copy link

Describe the bug

After the patient has been deleted from the original store, from another stores, that deleted patients still show up in the online lookup and can be processed for further vaccination events.

To reproduce

Steps to reproduce the behaviour:

  1. Create a patient in Store1 and sync
  2. Delete it and sync
  3. In Store2, go to Vaccination and search online; that deleted patient shows up
  4. Select it and see error: it lets you add vaccination event for deleted patient.

Expected behaviour

Once deleted, should not be able to further create any record.

Proposed Solution

Leave if you don't know how to fix/implement. Edit this issue description and explain here if you know the best path of implementing the fix within the codebase.

Version and device info

  • App version: latest

Additional context

Add any other context about the problem here.

@nishaDangol-Sussol nishaDangol-Sussol added Bug: ???? Placeholder; replace with 'development' or 'production' Project: K COVID-19 Vax Issues specifically related to K COVID-19 Vax project / customisations. labels Aug 16, 2022
@sworup sworup changed the title Vaccine can be processed for deleted patient Kiribati Vax: Vaccine can be processed for deleted patient in vaccination lookup window Aug 16, 2022
@sworup sworup added Bug: development Bug was found and believed to only be in development branches Priority: release blocker Effort: medium Medium effort story/task, estimated 2-5 days Docs: not needed and removed Bug: ???? Placeholder; replace with 'development' or 'production' labels Aug 16, 2022
@sworup sworup added this to the 8.6.0 milestone Aug 16, 2022
@sworup
Copy link
Contributor

sworup commented Aug 16, 2022

@nisha-dangol This is also the error for edit events.
Also I had fixed this with #4841 and #4842 for patient details. THis is mostly the same logic, but I thought this window uses the same list as in dispensing lookup list which is does not.
I have to replicate code from the earlier prs here also and maybe add some dispach logic updates.

@sworup sworup linked a pull request Aug 16, 2022 that will close this issue
9 tasks
FlorenceChashchina added a commit that referenced this issue Aug 16, 2022
…nt-from-being-given-vaccine

#4885 Disable deleted patient from being given vaccine
@FlorenceChashchina
Copy link
Contributor

Closed as completed in #4893

@nishaDangol-Sussol
Copy link
Author

Re-tested in the latest apk.

Deleted patients are not allowed to proceed with further vaccination event as long as it is in sync. But when we don't manual sync after the patient has been deleted in homestore, still a record can be created for the deleted patient! Issue here

@sworup
Copy link
Contributor

sworup commented Sep 1, 2022

The issue stemming from this issue is fixed but that fix stemmed another issue.
@nisha-dangol we can set this one to testing done as future bigs will be handled by future issue.

@sworup sworup mentioned this issue Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: development Bug was found and believed to only be in development branches Docs: not needed Effort: medium Medium effort story/task, estimated 2-5 days Priority: release blocker Project: K COVID-19 Vax Issues specifically related to K COVID-19 Vax project / customisations.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants