Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip extraneous white space from user input #1644

Open
CarlosNZ opened this issue Aug 19, 2024 · 1 comment
Open

Strip extraneous white space from user input #1644

CarlosNZ opened this issue Aug 19, 2024 · 1 comment
Labels
bug Something is broken :( Dev

Comments

@CarlosNZ
Copy link
Collaborator

CarlosNZ commented Aug 19, 2024

If users include white space at the end of their input, this can cause subsequent problems with Markdown rendering (e.g. wrapping in * * for italics).

So we should trim white space from all user input where possible. Places I can think of off the top of my head:

  • Reviewer comments
  • Reviewer overall comment
  • Text input form element
  • Long Text input form element
  • ??

Also, might be a good idea to have a "keepWhiteSpace" property for form inputs, as we might want to allow only white space as a valid response in some situations

@CarlosNZ CarlosNZ added bug Something is broken :( Dev labels Aug 19, 2024
@CarlosNZ
Copy link
Collaborator Author

Need to also make sure this works for pre-filled elements (i.e. that have a default property)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken :( Dev
Projects
None yet
Development

No branches or pull requests

1 participant