Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table -- mobile styles more like the Desktop view #1574

Closed
Tracked by #1548
CarlosNZ opened this issue Oct 31, 2023 · 1 comment · Fixed by #1582
Closed
Tracked by #1548

Table -- mobile styles more like the Desktop view #1574

CarlosNZ opened this issue Oct 31, 2023 · 1 comment · Fixed by #1582
Assignees

Comments

@CarlosNZ
Copy link
Collaborator

CarlosNZ commented Oct 31, 2023

Part of Epic #1548

Okay, so we have the tables working okay in a "stacked" view. However, the styles are just bare-bones and not that pretty (black boxes). Would be good if we could add a few of the table styles back to the mobile media query, so they look similar. (Don't have to be exactly the same, and probably should be a bit more "compact")

Current Desktop view:

Image

Current Mobile view:

Image

So I'm thinking:

  • lose the black border
  • slight spacing between rows
  • rounded corners
  • less padding inside cell
  • cell rows closer together

Also...

  • The mobile tables still expand past the viewport when there is really long text content in them:
Screenshot 2023-11-02 at 12 16 02 AM
@CarlosNZ CarlosNZ linked a pull request Nov 2, 2023 that will close this issue
CarlosNZ added a commit that referenced this issue Nov 2, 2023
@CarlosNZ
Copy link
Collaborator Author

CarlosNZ commented Nov 5, 2023

Closed by #1582

@CarlosNZ CarlosNZ closed this as completed Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants