Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile specific header labels for Tables when in mobile view #1569

Closed
CarlosNZ opened this issue Oct 31, 2023 · 1 comment · Fixed by #1573
Closed

Mobile specific header labels for Tables when in mobile view #1569

CarlosNZ opened this issue Oct 31, 2023 · 1 comment · Fixed by #1573
Assignees

Comments

@CarlosNZ
Copy link
Collaborator

Part of Epic #1548

When the tables are collapsed for Mobile, they look okay, but without header labels it's very difficult to make sense of what each bit of information is referring to, e.g.:

Screenshot 2023-10-31 at 2 28 30 PM

I think we should make a utility component called "TableHeaderLabel", and we wrap each Table.Cell contents in it. Then, in that component we determine if we're in mobile or not (using #1568 ) and if so, pre-pend the "header" label to it. And if not, just return the children unmodified.

We probably don't want this for all table cells though, so it should have a "disabled" prop that can be dynamically applied (for Data Views), or we just don't wrap it for static ones (such as the "Status" label on the Application List)

@CarlosNZ
Copy link
Collaborator Author

CarlosNZ commented Nov 5, 2023

Closed by #1573

@CarlosNZ CarlosNZ closed this as completed Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant