Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-assignment available for final decision. Causes form failure #943

Open
fergie-nz opened this issue Nov 2, 2022 · 3 comments
Open

Un-assignment available for final decision. Causes form failure #943

fergie-nz opened this issue Nov 2, 2022 · 3 comments
Assignees
Labels
bug Something is broken :(

Comments

@fergie-nz
Copy link
Contributor

Possible front end changes also required to remove button from un-assignment.

Un-assignment should not be available or visible.

Here the application is assigned to all users, yet admin is able to unassign
Screen Shot 2022-11-03 at 10 50 00 AM (2)

Admin unassigns and application fails
Screen Shot 2022-11-03 at 10 50 12 AM

@fergie-nz fergie-nz added Bug: development bug Something is broken :( labels Nov 2, 2022
@CarlosNZ
Copy link
Collaborator

CarlosNZ commented Nov 4, 2022

Okay, as mentioned in the meeting earlier today, allowing multiple people to be auto-assigned to a section breaks the integrity of the back-end and (in my opinion) creates more problems than it solves.

In fact, with this PR, being able to auto assign multiple people to the same review/stage/level will not be allowed.

Strongly suggest going back to the original behaviour where reviewers are simply "AVAILABLE" for assignment and have to self-assign themselves like they do everywhere else.

If anyone has a good reason why this shouldn't be like this, please explain it here. Cos allowing the database to exist in an inconsistent and problematic state (just look how many assignment bugs we cause!!) in order to save a user a couple of clicks is not worth it, so the argument for this will need to be pretty compelling.

@CarlosNZ
Copy link
Collaborator

CarlosNZ commented Nov 6, 2022

See also this issue, which is related: msupply-foundation/conforma-web-app#1423

We need to sort this ASAP -- should be #1 priority for the start of this week.

@CarlosNZ
Copy link
Collaborator

I think this has been sorted. Someone should check at some point, please, and close issue if so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken :(
Projects
None yet
Development

No branches or pull requests

2 participants