Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: User doesn't get correct permissions for old applications if added after they've expired #1119

Open
CarlosNZ opened this issue Jul 21, 2024 · 0 comments
Labels
bug Something is broken :( Dev

Comments

@CarlosNZ
Copy link
Collaborator

CarlosNZ commented Jul 21, 2024

When the back-end policies are doing their checks, for "review" permissions, they use review_assignments to get to reviews then applications.

The problem is, when a new user is used (or permissions added to existing user), they have no review assignments for completed applications, and they don't get re-generated as we ignore completed applications, and therefore they are unable to "extend" the applications.

Simplest fix would be to just included "expired" applications in the "refresh review assignments" process, but that's already very slow so would be reluctant to make it even slower.

Maybe we need to look at the "refresh review assignments" overall and find ways to speed it up.

@CarlosNZ CarlosNZ added bug Something is broken :( Dev labels Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken :( Dev
Projects
None yet
Development

No branches or pull requests

1 participant