Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File server can't handle files with illegal characters in filename #1100

Open
CarlosNZ opened this issue May 20, 2024 · 2 comments
Open

File server can't handle files with illegal characters in filename #1100

CarlosNZ opened this issue May 20, 2024 · 2 comments
Assignees
Labels
bug Something is broken :( importance: Should have Issue that should be included, not needed in MVP

Comments

@CarlosNZ
Copy link
Collaborator

CarlosNZ commented May 20, 2024

Suggested fix -- in "fileUpload" element, strip out any illegal characters on upload and save them with modified filenames.

Legal chars should be restricted to letters,numbers, space, and underscore (what about åccénted letters? -- need to test)

Illegal chars should be replaced with underscores, probably.

@CarlosNZ CarlosNZ added bug Something is broken :( importance: Should have Issue that should be included, not needed in MVP Urgent Address this first! labels May 20, 2024
@CarlosNZ CarlosNZ self-assigned this May 20, 2024
@CarlosNZ
Copy link
Collaborator Author

Alternate solution was to correctly escape the file names (percent-escaping) before sending them to the sendFile method. Working correctly now, so no need to restrict incoming file names at this point.

@CarlosNZ
Copy link
Collaborator Author

Re-opening this as found case where server actions are failing due to inappropriate characters -- need to investigate further

@CarlosNZ CarlosNZ reopened this Jun 26, 2024
@CarlosNZ CarlosNZ removed the Urgent Address this first! label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken :( importance: Should have Issue that should be included, not needed in MVP
Projects
None yet
Development

No branches or pull requests

1 participant