Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$(target).children("ul") vs $(target).find("ul") #117

Open
apapacy opened this issue Apr 13, 2018 · 0 comments
Open

$(target).children("ul") vs $(target).find("ul") #117

apapacy opened this issue Apr 13, 2018 · 0 comments

Comments

@apapacy
Copy link

apapacy commented Apr 13, 2018

...
this.steps        = $(target).children("ul").children("li").children("a"); // Get all anchors
...
if($this.target.children('ul').length == 0 )
...

These conditions look too strict. Does not it make sense to replace them with others?

...
this.steps        = $(target).find("ul").children("li").children("a"); // Get all anchors
...
if($this.target.find('ul').length == 0 )
...

Or can I pass the list in the configuration parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant