Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore support for Reanimated 3.15+ in v2 with frame processors #3125

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from

Conversation

tomekzaw
Copy link
Contributor

@tomekzaw tomekzaw commented Aug 7, 2024

What

This PR aligns RNVisionCamera v2 with frame processors enabled with latest changes in Reanimated 3 (i.e. mostly directory tree changes and adding a separate worklets prefab on Android).

Without this fix, you would get the following error:

> Task :react-native-vision-camera:buildCMakeDebug[arm64-v8a] FAILED
C/C++: ninja: Entering directory `/Users/tomekzaw/RNOS/react-native-vision-camera/android/.cxx/Debug/m2d3n5o2/arm64-v8a'
C/C++: ld: error: undefined symbol: reanimated::extractWorkletRuntime(facebook::jsi::Runtime&, facebook::jsi::Value const&)
C/C++: ld: error: undefined symbol: reanimated::extractShareableOrThrow(facebook::jsi::Runtime&, facebook::jsi::Value const&, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&)
C/C++: ld: error: undefined symbol: typeinfo for reanimated::Shareable
C/C++: ld: error: undefined symbol: typeinfo for reanimated::ShareableWorklet
C/C++: ld: error: undefined symbol: reanimated::getCallGuard(facebook::jsi::Runtime&)
C/C++: clang-12: error: linker command failed with exit code 1 (use -v to see invocation)

Changes

  • Bump react-native-reanimated in example app on Android and iOS
  • Update path in android/build.gradle that is used to determine if Reanimated 3 is installed
  • Update prefab name in android/CMakeLists.txt

Tested on

Tested on Android emulator and iOS simulator.

Related issues

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 10:41am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant